Open
Conversation
mod
requested changes
Dec 30, 2022
Contributor
mod
left a comment
mod
left a comment
There was a problem hiding this comment.
Please add a README.md file which explain how the package should be used, and maybe godoc for the most important file
calj
reviewed
Jan 9, 2023
nats/handler.go
Outdated
|
|
||
| // For Checking compatibility | ||
| var ( | ||
| _ EventHandler = (*NatsEventHandler)(nil) |
Member
There was a problem hiding this comment.
I think I prefer to put those lines into the test file, even in a test so it's more clear this is testing the interface compliance. It can eventually save few bytes of memory footprint.
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.